Add seek step to enable faster silence detection #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marciomazza
commented
Aug 21, 2017
|
|
||
| [pep8] | ||
| max-line-length = 100 |
There was a problem hiding this comment.
I noticed the max columns used now in the project is 99, by running this at the project root:
find -name '*.py' | xargs cat | awk '{print length}' | sort | tail -n 1
This config makes autopep8 respect that maximum line length.
marciomazza
force-pushed
the
seek_step_for_detect_silence
branch
from
6e89589 to
2a48cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence detection can be very slow on large files.
One way of speeding it up is to seek for silence chunks at steps, instead of trying every single millisecond as a chunk start.
This pull adds such a seek step to the detection, as a parameter at the end of the involved functions, with a default value of one. That makes it backwards compatible.
One possible future improvement would be to parallelize the detection.